Fix getInstanceFiles #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Il existe pourtant un test fonctionnel de cette fonctionnalité : Au passage, je viens de créer un PR sur Hesperides pour mieux documenter le rôle de ce query param dans le Swagger d'Hesperides : sncf-connect-tech/hesperides#861 À moins que tu ne voies une bonne raison de modifier le comportement par défaut de cette méthode, au risque d'avoir un impact sur sa rétrocompatibilité, je te propose de plutôt introduire un paramètre optionnel Idéalement, su tu as le temps, pourrais-tu inclure dans cette MR :
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually,
getInstanceFilesmethod isn't working because thesimulatequery param is missing.Hesperides frontend set it to true.